Open
Conversation
01df5d8 to
9e29643
Compare
|
is it possible to have it merged and released some time soon ? 🙏 |
9e29643 to
37f7ff5
Compare
HayesGordon
reviewed
Mar 13, 2026
cc332b0 to
789cabd
Compare
BREAKING CHANGE: minimum nitro-modules version is now 0.35.0
Nitro 0.35 generates final ViewManager classes, preventing onDropViewInstance override needed for view lifecycle cleanup. Added a postprocess script to patch the generated class as open.
789cabd to
a4edac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades nitrogen CLI and nitro-modules runtime to 0.35.0. Fixes
ArrayBufferHolder→ArrayBufferrename and regenerates all nitrogen bindings.Nitro 0.35 made generated ViewManagers
final(nitro#1181), which broke ourRiveViewManager.onDropViewInstance()override needed for proper view lifecycle cleanup (#46). Added a nitrogen postprocess script that patchesHybridRiveViewManagerback toopenso we can subclass it again.Without
onDropViewInstance,onDetachedFromWindowdisposes Rive resources on every navigation (not just permanent removal), causing state loss. GC-based cleanup was tested and confirmed unreliable — neither Hermes GC nor JVM GC triggers dispose.Reproducer: NavigationLifecycle.tsx
Uses counter.riv with a tap counter. Navigate to QuickStart and back; without the fix the counter resets to 0.
BREAKING CHANGE: minimum nitro-modules version is now 0.35.0
Closes: #169